jewel: rgw: don't loop forever when reading data from 0 sized segment. #11626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 0 sized segment can arise depending on how the client uploads the object in the first place. The cpu loop then happens during a swift `GET'. Signed-off-by: Marcus Watts <mwatts@redhat.com> (cherry picked from commit 46c5f97)
oritwas
changed the title
|
jenkins test this please (jenkins slave failure) |
|
@oritwas the rgw run has lots of failures. Are there specific jobs showing this patch does the right thing ? |
ghost
changed the title
|
We have valgrind errors in the teuthology run |
oritwas
changed the title
|
@dachary the extra commit is just for testing. |
oritwas
force-pushed
the
wip-jewel-11567
branch
from
c128e99
to
2f9a5be
Compare
|
new run on mira machine type: |
oritwas
changed the title
|
@dachary this valgrind issue happens only on vps and happens on latest jewel: http://pulpito.ceph.com/owasserm-2016-10-26_11:19:10-rgw-jewel---basic-vps/ We can merge this fix. |
ghost
merged commit 
theanalyst
changed the title
theanalyst
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17693
The 0 sized segment can arise depending on how
the client uploads the object in the first place.
The cpu loop then happens during a swift `GET'.
Signed-off-by: Marcus Watts mwatts@redhat.com
(cherry picked from commit 46c5f97)