upstart: start ceph-all after static-network-up #11631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting on runlevel [2345] allows the ceph services to start before all of the networking is configured. This introduces a race condition which allows a service to start before the network it binds to is available. Add the static-network-up event as a dependency for the start on directive in order to start the ceph services after all of the network stanzas have been processed and executed in the /etc/network/interfaces and /etc/network/interfaces.d/*.conf files. Fixes: http://tracker.ceph.com/issues/17689 Signed-off-by: Billy Olsen <billy.olsen@gmail.com>
|
retest this please |
ghost
added
|
@javacruft care to review ? |
ghost
approved these changes
Nov 23, 2016
|
@javacruft thanks ! |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting on runlevel [2345] allows the ceph services to
start before all of the networking is configured. This
introduces a race condition which allows a service to start
before the network it binds to is available.
Add the static-network-up event as a dependency for the start
on directive in order to start the ceph services after all of
the network stanzas have been processed and executed in the
/etc/network/interfaces and /etc/network/interfaces.d/*.conf
files.
Fixes: http://tracker.ceph.com/issues/17689
Signed-off-by: Billy Olsen billy.olsen@gmail.com