librados: postpone cct deletion #11659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
tchaikov
force-pushed
the
wip-delete-cct-later
branch
from
1434316
to
dd44cf5
Compare
|
changelog
|
RefCountedObject::put() prints log using cct, but RadosClient relinquishes the reference to cct too early, so when its `RefCountedObject` member variables print log when they are destructed, the cct is already freed. hence we have a segfault. to address this problem, we need postpone destructure of it after all other RefCountedObject member variables are destroyed. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-delete-cct-later
branch
from
dd44cf5
to
8b19229
Compare
|
changelog
|
|
http://pulpito.ceph.com/kchai-2016-10-29_03:47:14-rados-wip-kefu-testing---basic-mira/ all failed tests are already tracked on tracker, a new failed noted down at http://tracker.ceph.com/issues/17743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
debug refsis enabled, RefCountedObject::put() prints log usingcct, but RadosClient relinquishes the reference to cct too early, so its
when its
RefCountedObjectmember variables print log when they aredestructed, the cct is freed. so we need postpone destructure of it
after all other RefCountedObject member variables are destroyed.
Signed-off-by: Kefu Chai kchai@redhat.com