rgw: Class member cookie is not initialized correctly in some coroutine's constructor. #11673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsw
force-pushed
the
fix-rgw-initbucketshardsync-bug
branch
from
6ae35b3
to
e8b9c2d
Compare
|
@oritwas I'm going with harmless cleanup? |
|
lgtm |
zhangsw
force-pushed
the
fix-rgw-initbucketshardsync-bug
branch
from
e8b9c2d
to
b77d4fe
Compare
liewegas
changed the title
|
@zhangsw , can you rebase? |
zhangsw
force-pushed
the
fix-rgw-initbucketshardsync-bug
branch
from
b77d4fe
to
a934913
Compare
|
@oritwas , rebase done. |
oritwas
approved these changes
Nov 10, 2016
RGWInitBucketShardSyncStatusCoroutine and RGWInitDataSyncStatusCoroutine. Signed-off-by: Zhang Shaowen <zhangshaowen@cmss.chinamobile.com>
zhangsw
force-pushed
the
fix-rgw-initbucketshardsync-bug
branch
from
a934913
to
eb4f0ac
Compare
|
jenkins test this please (eio now ignored in master) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookie has been defined as a class member, and is not initialized correctly because we define a local variable named cookie, which is not not expected.
Signed-off-by: Zhang Shaowen zhangshaowen@cmss.chinamobile.com