os/bluestore: fix _split_collections race with osr_reap #11748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ifed01 mind taking a look? |
ifed01
reviewed
Nov 3, 2016
| // shortly by _osr_reap_done, but it's awkward to block for that (and | ||
| // a waste of time). Instead, explicitly remove them from the shared blob | ||
| // map. | ||
| c->shared_blob_set.violently_clear(); | ||
| assert(c->shared_blob_set.empty()); |
There was a problem hiding this comment.
no need for this assert any more.
ifed01
reviewed
Nov 3, 2016
| // shortly by _osr_reap_done, but it's awkward to block for that (and | ||
| // a waste of time). Instead, explicitly remove them from the shared blob | ||
| // map. | ||
| c->shared_blob_set.violently_clear(); | ||
| assert(c->shared_blob_set.empty()); | ||
| assert(d->shared_blob_set.empty()); |
There was a problem hiding this comment.
Not sure if this makes much sense but is it possible that destination collection struggles (or will struggle one day) with the same issue? Does it worth to clear its shared_blob_set the same way? Just in case...
|
The dest collection is always brand new and empty, so if anything we
would want to assert that's the case. Weird that we're clearing it
currently.. I'll clean it up tho
|
The SharedBlobSet may not yet be empty at split time because previous transactions may not have been reaped, leaving some Blobs still alive even after the cache refs are cleared. Drop them explicitly here (they will go away shortly). Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore-split
branch
from
9c34934
to
d420986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SharedBlobSet may not yet be empty at split time because previous
transactions may not have been reaped, leaving some Blobs still alive
even after the cache refs are cleared. Drop them explicitly here (they
will go away shortly).
Signed-off-by: Sage Weil sage@redhat.com