jewel: disable virtual hosting of buckets when no hostnames are configured #11760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic (added in 46aae19) for falling back to just using the hostname as the possible bucket name contained an accidental inversion, because RGWHandler_REST::validate_bucket_name returns success as zero. Backport: jewel Fixes: http://tracker.ceph.com/issues/17136 Re-Fixes: http://tracker.ceph.com/issues/15975 Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com> (cherry picked from commit 70e0289)
if no hostnames are configured, all requests were treated as virtual hosted buckets. require at least one hostname in hostnames_set to consider setting in_hosted_domain Fixes: http://tracker.ceph.com/issues/17440 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 7c7ad3c)
Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 36203c2)
Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit aa34b98)
std::accumulate() was appending hostnames without commas or spaces Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 2d6efe8)
ghost
changed the base branch from
|
jenkins test this please (test-erasure-eio failed) |
|
jenkins test this please (general jenkins failure) |
ghost
pushed a commit
that referenced
this pull request
Nov 9, 2016
…when no hostnames are configured Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
assigned
|
@oritwas does this backport look good to merge ? It passed the rgw suite http://tracker.ceph.com/issues/17851#note-3 . Note that it will not be in 10.2.4, reason why it targets jewel-next. |
|
This is on |
|
@robbat2 The commits in this PR are in |
|
Yes, I see in 5b402f8 that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17769