Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: snap_get_limit compatibility check #11766

Merged
merged 1 commit into from Nov 5, 2016

Conversation

trociny
Copy link
Contributor

@trociny trociny commented Nov 3, 2016

This is not critical and it may fail e.g. with ENOTSUP when running
an upgraded client on an older cluster.

Signed-off-by: Mykola Golub mgolub@mirantis.com

@trociny
Copy link
Contributor Author

trociny commented Nov 3, 2016

@dillaman May be also don't fail when image.get_group returns an error? It looks like it does not return ENOTSUP in upgrade:client tests, still the failure does not look critical to abort rbd info.

@dillaman
Copy link

dillaman commented Nov 3, 2016

@trociny Looking at the implementation of "get_group", it should just return an empty group spec w/o returning an error if unsupported (since the group information is fetched during the RefreshRequest state machine and cached).

Perhaps we should handle the EOPNOTSUPP case within internal.cc and set the max to UINT64_MAX if you get this error back from the OSD.

@dillaman dillaman added this to the kraken milestone Nov 3, 2016
@trociny trociny force-pushed the wip-rbd-info-fix-upgrade-client branch from c6aa762 to 0504201 Compare November 3, 2016 16:34
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
@trociny trociny force-pushed the wip-rbd-info-fix-upgrade-client branch from 0504201 to c1f374e Compare November 3, 2016 16:36
@trociny trociny changed the title rbd: don't fail if snap_get_limit returned with error librbd: snap_get_limit compatibility check Nov 3, 2016
@trociny
Copy link
Contributor Author

trociny commented Nov 3, 2016

@dillaman Thanks, updated

@dillaman
Copy link

dillaman commented Nov 3, 2016

lgtm

@dillaman dillaman merged commit 8adf384 into ceph:master Nov 5, 2016
@trociny trociny deleted the wip-rbd-info-fix-upgrade-client branch November 5, 2016 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants