boost: embedded #11817
Merged
boost: embedded #11817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This implements option ceph#4 for external boost, based on upstream discussion. In option ceph#4: 1. boost is added as a submodule 2. builds default to using the attached boost module 3. building against a system-provided boost is supported, but must be configured explicitly Because all of the boost components are attached as nested submodules in the upstream boost repository, neither the nested submodules nor the root boost submodule have been cloned into modules in github.com/ceph (acked by Sage). Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Build Boost using the src/boost submodule, unless overridden by -DWITH_SYSTEM_BOOST. If -DBOOST_J=<n> is provided, builds Boost with <n> jobs. Boost builds in the configured Build directory. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Pull-up Boost to the commit which merged the upstream fix for upstream Boost/iostreams bug ceph#11860 (template arity warnings), per discussion in core. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
This lets us build boost with all processors. Signed-off-by: Sage Weil <sage@redhat.com> Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
The ceph manager change added a separate Boost dependency check, add it to the combined section. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Pullup to just the merges on Sep 10 fixes an obvious compile problem, but there are other relevant changes. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
force-pushed
the
wip-boost-3
branch
from
5abf6f2
to
9dd5b70
Compare
liewegas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a pull up to current boost/master. I've included this as an alternative to a pull up between Sept 10 and Nov 7, which will be time consuming to bisect.