crush: remove the crush_lock #11830
Merged
crush: remove the crush_lock #11830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
adamemerson
force-pushed
the
wip-crush-unlocked
branch
from
7345d66
to
eeec50d
Compare
|
I rebuilt and re-ran make check. Everything passed except for osd-scrub-repair.sh and osd-scrub-snaps.sh which were also failing on master last time I checked, so I don't think they're triggered by anything here. |
Then add it to the working state. It would be very nice if we didn't have to take a lock to calculate a crush placement. By moving the permutation array into the working data, we can treat the CRUSH map as immutable. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Much like Arlo Guthrie, I decided that one big pile is better than two little piles. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Now that we no longer use the map as a scratch pad, we don't need to lock during rule execution. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
adamemerson
force-pushed
the
wip-crush-unlocked
branch
from
eeec50d
to
cafdc65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not keep mutable state around in the CRUSH map, move it out into a separate workspace that gets passed in. Making the CRUSH map read-only allows concurrency.