jewel: monitor assertion failure when deactivating mds in (invalid) fscid 0 #11862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit de6c36a)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 8934e95)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 59de991)
This allows us to reuse code in parse_filesystem and avoid get_filesystem which may fail if the fscid does not exist. This would result in the program (mon) aborting due to the uncaught exception. Fixes: http://tracker.ceph.com/issues/17518 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit edc78e4)
ghost
self-assigned this
ghost
changed the base branch from
|
jenkins test this please (general jenkins failure) |
ghost
pushed a commit
that referenced
this pull request
Nov 9, 2016
…tivating mds in (invalid) fscid 0 Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@jcsp does this backport look good to merge ? It passed the fs suite http://tracker.ceph.com/issues/17851#note-5 (except for valgrind failures and one java test failure that also fail on the jewel branch ). Note that it will not be included in 10.2.4, reason why it targets jewel-next. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17582