Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jewel: rgw: the value of total_time is wrong in the result of 'radosgw-admin log show' opt #11876

Merged
merged 1 commit into from Feb 1, 2017
Merged

jewel: rgw: the value of total_time is wrong in the result of 'radosgw-admin log show' opt #11876

merged 1 commit into from Feb 1, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 9, 2016

@weiqiaomiao @ldachary
rgw: fix the field 'total_time' of log entry in log show opt
6a3c10f 
Fixes: http://tracker.ceph.com/issues/17598

Signed-off-by: weiqiaomiao <wei.qiaomiao@zte.com.cn>
(cherry picked from commit 8f4825c)
@ghost ghost self-assigned this Nov 9, 2016
@ghost ghost added this to the jewel milestone Nov 9, 2016
@ghost ghost added bug-fix rgw labels Nov 9, 2016
@ghost ghost changed the base branch from jewel to jewel-next November 9, 2016 15:29
@ghost
Copy link
Author

ghost commented Nov 9, 2016

jenkins test this please (general jenkins failure)

ghost pushed a commit that referenced this pull request Nov 9, 2016
Merge pull request #11876: jewel: rgw: the value of total_time is wro…
196c0a0 
…ng in the result of 'radosgw-admin log show' opt

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost assigned yehudasa Nov 11, 2016
@ghost
Copy link
Author

ghost commented Nov 11, 2016

@yehudasa does this backport look good to merge ? It passed the rgw suite http://tracker.ceph.com/issues/17851#note-3 . Note that it will not be in 10.2.4, reason why it targets jewel-next.

ghost pushed a commit that referenced this pull request Nov 23, 2016
Merge pull request #11876: jewel: rgw: the value of total_time is wro…
eceee3e 
…ng in the result of 'radosgw-admin log show' opt

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Dec 5, 2016
Merge pull request #11876: jewel: rgw: the value of total_time is wro…
d1220dd 
…ng in the result of 'radosgw-admin log show' opt

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link
Author

ghost commented Dec 5, 2016

@yehudasa ping

@ghost ghost changed the base branch from jewel-next to jewel December 21, 2016 23:30
@ghost
Copy link
Author

ghost commented Dec 21, 2016

check this please

@smithfarm
Copy link
Contributor

This passed more rgw runs at http://tracker.ceph.com/issues/17851#note-50 and http://tracker.ceph.com/issues/17851#note-58

@smithfarm smithfarm merged commit d71c75a into ceph:jewel Feb 1, 2017
@smithfarm
Copy link
Contributor 

(11:46:45 AM) smithfarm: owasserm: thanks. For jewel integration rgw, then, what it comes down to is verifying that these 6 valgrind failures are all libtcmalloc-related: http://pulpito.front.sepia.ceph.com/smithfarm-2017-01-31_12:35:14-rgw-wip-jewel-backports-distro-basic-smithi/
(11:46:58 AM) smithfarm: owasserm: I will do that now
(11:47:05 AM) owasserm: smithfarm, thanks
(11:47:33 AM) smithfarm: owasserm: and assuming they are tcmalloc related, you said I can directly merge all the rgw PRs? Or do you want me to ask you for review in the PRs first?
(11:47:53 AM) owasserm: smithfarm, yes you can merge them
(11:48:19 AM) smithfarm: ok, will merge and do at least one or two more rgw runs before passing 10.2.6 to QE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yehudasa yehudasa

Labels
bug-fix rgw
Projects
None yet
Milestone
jewel
3 participants
@smithfarm @yehudasa @weiqiaomiao