New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jewel: ceph-create-keys loops forever #11884
Conversation
Reviewed-by: Loic Dachary <ldachary@redhat.com>
15b7a7e
to
7a9b8a4
Compare
It passed the rados (http://tracker.ceph.com/issues/17851#note-4) suite. It also passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17851#note-7) suites, except for one job which should be fixed by ceph/ceph-qa-suite#1256 and does not seem related to this pull request. Note that it won't be included in 10.2.4, reason why it targets jewel-next. |
@smithfarm could you please repush without 2538ed4 ? It has already been merged in jewel. |
7a9b8a4
to
9880093
Compare
@dachary Looks like "git rebase ceph/jewel-next" was enough to get rid of it :-) |
flake8 runtests: PYTHONHASHSEED='3298675756' flake8 runtests: commands[0] | flake8 --ignore=H105,H405,E127 ceph_disk tests ceph_disk/main.py:173:1: E305 expected 2 blank lines after class or function definition, found 1 ceph_disk/main.py:5011:1: E305 expected 2 blank lines after class or function definition, found 1 ERROR: InvocationError: '/home/jenkins-build/build/workspace/ceph-pull-requests/src/ceph-disk/.tox/flake8/bin/flake8 --ignore=H105,H405,E127 ceph_disk tests' |
@dachary That's odd; this PR doesn't touch ceph-disk as far as I can see? |
@smithfarm right, this is odd... I must have merged something that triggers that problem |
@smithfarm you should remove 8692d1b : the problem is not the extra lines, it is that flake8 should not complain about them. Unless ... it started doing so by default ! |
8692d1b
to
9880093
Compare
@dachary Removed. |
jenkins test this please (flake8 error now fixed in jewel-next) |
Reviewed-by: Loic Dachary <ldachary@redhat.com>
It passed the rados (http://tracker.ceph.com/issues/17851#note-12) suite. It also passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17851#note-15) suites. |
http://tracker.ceph.com/issues/17754