Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: ceph-create-keys loops forever #11884

Merged
3 commits merged into from Dec 5, 2016
Merged

Conversation

smithfarm
Copy link
Contributor

@smithfarm smithfarm self-assigned this Nov 9, 2016
@smithfarm smithfarm added this to the jewel milestone Nov 9, 2016
ghost pushed a commit that referenced this pull request Nov 9, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@smithfarm smithfarm changed the base branch from jewel to jewel-next November 10, 2016 00:44
@ghost
Copy link

ghost commented Nov 14, 2016

It passed the rados (http://tracker.ceph.com/issues/17851#note-4) suite. It also passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17851#note-7) suites, except for one job which should be fixed by ceph/ceph-qa-suite#1256 and does not seem related to this pull request. Note that it won't be included in 10.2.4, reason why it targets jewel-next.

@ghost
Copy link

ghost commented Nov 14, 2016

@smithfarm could you please repush without 2538ed4 ? It has already been merged in jewel.

Alfredo Deza added 3 commits November 14, 2016 17:08
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 32cedd2)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 8f84681)
… not forever

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit bea802b)
@smithfarm
Copy link
Contributor Author

@dachary Looks like "git rebase ceph/jewel-next" was enough to get rid of it :-)

@ghost
Copy link

ghost commented Nov 14, 2016

flake8 runtests: PYTHONHASHSEED='3298675756'
flake8 runtests: commands[0] | flake8 --ignore=H105,H405,E127 ceph_disk tests
ceph_disk/main.py:173:1: E305 expected 2 blank lines after class or function definition, found 1
ceph_disk/main.py:5011:1: E305 expected 2 blank lines after class or function definition, found 1
ERROR: InvocationError: '/home/jenkins-build/build/workspace/ceph-pull-requests/src/ceph-disk/.tox/flake8/bin/flake8 --ignore=H105,H405,E127 ceph_disk tests'

@smithfarm
Copy link
Contributor Author

@dachary That's odd; this PR doesn't touch ceph-disk as far as I can see?

@ghost
Copy link

ghost commented Nov 14, 2016

@smithfarm right, this is odd... I must have merged something that triggers that problem

@ghost
Copy link

ghost commented Nov 14, 2016

@smithfarm you should remove 8692d1b : the problem is not the extra lines, it is that flake8 should not complain about them. Unless ... it started doing so by default !

@smithfarm
Copy link
Contributor Author

@dachary Removed.

@ghost
Copy link

ghost commented Nov 15, 2016

jenkins test this please (flake8 error now fixed in jewel-next)

ghost pushed a commit that referenced this pull request Nov 23, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link

ghost commented Dec 5, 2016

It passed the rados (http://tracker.ceph.com/issues/17851#note-12) suite. It also passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17851#note-15) suites.

@ghost ghost merged commit 01e8960 into ceph:jewel-next Dec 5, 2016
@smithfarm smithfarm deleted the wip-17754-jewel branch December 5, 2016 16:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant