os/filestore/HashIndex: fix list_by_hash_* termination on reaching end #11898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-filestore-hashindex
branch
from
32f4cd3
to
da520ed
Compare
If we set *next to max, then the caller (a few lines up) doesn't terminate the loop and will keep trying to list objects in every following hash dir until it reaches the end of the collection. In fact, if we have an end bound we will never to an efficient listing unless we hit the max first. For one user, this was causing OSD suicides when scrub ran because it wasn't able to list all objects before the timeout. In general, this would cause scrub to stall a PG for a long time and slow down requests. Broken by refactor in 921c458. Fixes: http://tracker.ceph.com/issues/17859 Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-filestore-hashindex
branch
from
da520ed
to
c518026
Compare
|
Manual test resolves the problem |
athanatos
approved these changes
Nov 10, 2016
|
Tracker ticket is http://tracker.ceph.com/issues/17859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we set *next to max, then the caller (a few lines up) doesn't terminate
the loop and will keep trying to list objects in every following hash
dir until it reaches the end of the collection. In fact, if we have an
end bound we will never to an efficient listing unless we hit the max
first.
For one user, this was causing OSD suicides when scrub ran because it
wasn't able to list all objects before the timeout. In general, this would
cause scrub to stall a PG for a long time and slow down requests.
Signed-off-by: Sage Weil sage@redhat.com