hammer: tools: crushtool --compile generates output despite missing item #11931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
force-pushed
the
wip-17333-hammer
branch
from
82eb08c
to
753a6be
Compare
do not output compiled crush map if anything goes wrong when parsing crush map. Fixes: http://tracker.ceph.com/issues/17306 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit b2c0a07) Conflicts: src/test/cli/crushtool/compile-decompile-recompile.t (hammer needs $TESTDIR/ prefix)
smithfarm
force-pushed
the
wip-17333-hammer
branch
from
753a6be
to
7ad7de6
Compare
smithfarm
changed the title
smithfarm
added a commit
that referenced
this pull request
Nov 18, 2016
…es output despite missing item Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Nov 20, 2016
…es output despite missing item Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
@tchaikov @badone This backport passed a rados suite at http://tracker.ceph.com/issues/17151#note-7 with failures that I believe have been addressed (except for http://tracker.ceph.com/issues/15139 which is caused by the build system no longer providing dumpling-era packages). I have rebuilt the integration branch to include the two fixes and scheduled a new run at http://tracker.ceph.com/issues/17151#note-14 Do you think it's OK to merge provided the second run succeeds? |
smithfarm
added a commit
that referenced
this pull request
Nov 21, 2016
…es output despite missing item Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Nov 21, 2016
…es output despite missing item Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
Second run succeeded; third run here: http://pulpito.front.sepia.ceph.com/smithfarm-2016-11-21_11:52:41-rados-hammer-backports---basic-smithi/ |
|
@smithfarm good to merge! thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17333