Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hammer: rbd: export diff should open image as read-only #11948

Merged
merged 1 commit into from Nov 23, 2016

Conversation

smithfarm
Copy link
Contributor

@smithfarm smithfarm self-assigned this Nov 13, 2016
@smithfarm smithfarm added this to the hammer milestone Nov 13, 2016
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dillaman dillaman changed the title Fix coding mistake in pre-refactor rbd shell hammer: rbd: export diff should open image as read-only Nov 16, 2016
Fixes: http://tracker.ceph.com/issues/17671

Signed-off-by: liyankun <lioveni99@gmail.com>
smithfarm added a commit that referenced this pull request Nov 18, 2016
… as read-only

Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm added a commit that referenced this pull request Nov 20, 2016
… as read-only

Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm added a commit that referenced this pull request Nov 21, 2016
… as read-only

Reviewed-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor Author

@dillaman This PR was included in this rbd suite: http://tracker.ceph.com/issues/17151#note-12

That run has two issues: the first (OSD suicide timeout) is not reproducible and looks like environmental noise. Then there is a reproducible qemu-iotests failure which matches http://tracker.ceph.com/issues/10773

Can you take a look? If you think the qemu-iotests failure is unrelated, I guess this PR could be merged?

smithfarm added a commit that referenced this pull request Nov 21, 2016
… as read-only

Reviewed-by: Nathan Cutler <ncutler@suse.com>
@dillaman
Copy link

@smithfarm lgtm

@smithfarm smithfarm merged commit 6e1ae86 into ceph:hammer Nov 23, 2016
@smithfarm smithfarm deleted the wip-17671-hammer branch November 23, 2016 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants