Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: tools: snapshotted RBD extent objects can't be manually evicted from a cache tier #11968

Merged
3 commits merged into from Dec 6, 2016

Conversation

ddiss
Copy link
Contributor

@ddiss ddiss commented Nov 14, 2016

In Jewel, snapshotted objects can't be manually evicted from a cache tier using cache-flush-evict-all . Backport three minor changes that implement and test this functionality.

http://tracker.ceph.com/issues/17895

…ush-evict-all"

Signed-off-by: Mingxin Liu <mingxin@xsky.com>
(cherry picked from commit b1cf2d9)
…sh/cache-evict

Signed-off-by: Mingxin Liu <mingxin@xsky.com>
(cherry picked from commit 3dd9fa2)
Signed-off-by: Mingxin Liu <mingxin@xsky.com>
(cherry picked from commit 383177b)
@smithfarm smithfarm added this to the jewel milestone Nov 14, 2016
@ghost
Copy link

ghost commented Nov 14, 2016

jenkins test this please (general jenkins failure)

@ghost ghost self-assigned this Nov 14, 2016
@ghost ghost changed the title Allow manual eviction of snapshotted objects jewel: Snapshotted RBD extent objects can't be manually evicted from a cache tier Nov 14, 2016
@ghost
Copy link

ghost commented Nov 15, 2016

jenkins test this please (flake8 error now fixed in jewel-next)

@ddiss
Copy link
Contributor Author

ddiss commented Nov 22, 2016

@dachary: anything needed from my side here?

@ghost
Copy link

ghost commented Nov 22, 2016

@ddiss all good, thanks for asking. The error was unrelated to your backport, it was environmental.

ghost pushed a commit that referenced this pull request Nov 23, 2016
…t be manually evicted from a cache tier

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost changed the title jewel: Snapshotted RBD extent objects can't be manually evicted from a cache tier jewel: tools: snapshotted RBD extent objects can't be manually evicted from a cache tier Dec 5, 2016
@ghost ghost assigned tchaikov Dec 5, 2016
@ghost
Copy link

ghost commented Dec 5, 2016

@tchaikov does this backport look good to merge ? It passed the rados (http://tracker.ceph.com/issues/17851#note-12) suite. It also passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17851#note-15) suites. Note that it won't be included in 10.2.4, reason why it targets jewel-next.

ghost pushed a commit that referenced this pull request Dec 5, 2016
…ts can't be manually evicted from a cache tier

Reviewed-by: Loic Dachary <ldachary@redhat.com>
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchaikov tchaikov removed their assignment Dec 6, 2016
@ghost ghost merged commit bbafd7f into ceph:jewel-next Dec 6, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants