Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph-create-keys: Add connection timeouts. #11995

Merged
merged 1 commit into from Mar 1, 2017
Merged

ceph-create-keys: Add connection timeouts. #11995

merged 1 commit into from Mar 1, 2017

Conversation

oms4suse
Copy link
Contributor

ceph commands will hang indefinitely if called without a parameter:

--connect-timeout

Signed-off-by: Owen Synge osynge@suse.com

@smithfarm smithfarm assigned smithfarm and unassigned smithfarm Nov 15, 2016
@smithfarm smithfarm changed the title src.ceph-create-keys: Add connection timeouts. ceph-create-keys: Add connection timeouts. Nov 15, 2016
@ghost
Copy link

ghost commented Nov 16, 2016

jenkins test this please (eio, now fixed in master)

@ghost
Copy link

ghost commented Nov 16, 2016

jenkins test this please (tox bug, now fixed in master)

@oms4suse
Copy link
Contributor Author

Since the jenkins error was:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/osd-crush.sh:187: TEST_add_ruleset_failed: for i in '$(seq 3 255)'
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/osd-crush.sh:189: TEST_add_ruleset_failed: cat
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/osd-crush.sh:201: TEST_add_ruleset_failed: crushtool --compile testdir/osd-crush/crushmap.txt -o testdir/osd-crush/crushmap
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/osd-crush.sh:202: TEST_add_ruleset_failed: ceph osd setcrushmap -i testdir/osd-crush/crushmap
set crush map
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/osd-crush.sh:203: TEST_add_ruleset_failed: grep 'Error ENOSPC'
Error ENOSPC: failed to add rule 256 because (28) No space left on device
ceph-mon: mon.noname-a 127.0.0.1:7104/0 is local, renaming to mon.a

This seems unrelated so I shall rebase to master and so see if this issue is resolved.

@oms4suse
src.ceph-create-keys: Add connection timeouts.
0c7af43 
ceph commands will hang indefinitely if called without a parameter:

    --connect-timeout

Signed-off-by: Owen Synge <osynge@suse.com>
@oms4suse oms4suse force-pushed the wip_timeouts_ceph-create-keys branch from 638b098 to 0c7af43 Compare November 17, 2016 09:28
@smithfarm
Copy link
Contributor

Jenkins test this please

@smithfarm
Copy link
Contributor

@oms4suse You don't have to rebase to trigger re-test. It's enough to post a comment that contains the phrase "test this please".

@smithfarm
Copy link
Contributor

@oms4suse Is this something you will want to backport to jewel?

@oms4suse
Copy link
Contributor Author

@smithfarm thanks for the tip about the phrase.
@smithfarm Its just a small issue that occurs, only with misconfiguration but I see no reason to not back port to jewel.

@smithfarm
Copy link
Contributor

@oms4suse For backport it would be helpful if you could open a tracker issue and link it with this PR by posting the URL of the PR in the tracker and also by adding a line to the commit message: Fixes: http://tracker.ceph.com/issues/$ISSUE_NUMBER right above the Signed-off-by line. In the tracker, tlag the issue for backport by typing "jewel" in the Backport field. Thanks!

@ghost ghost added tools core and removed tools labels Nov 17, 2016
@jan--f jan--f deleted the wip_timeouts_ceph-create-keys branch February 8, 2017 20:04
@tchaikov tchaikov merged commit 2f157ae into ceph:master Mar 1, 2017
@tchaikov
Copy link
Contributor

tchaikov commented Mar 1, 2017

please note, --connect-timeout is not respected by ceph cli anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
3 participants
@oms4suse @smithfarm @tchaikov