Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: Error EINVAL: removing mon.a at 172.21.15.16:6789/0, there will be 1 monitors #11999

Merged
merged 2 commits into from Dec 1, 2016

Conversation

Abhishekvrshny
Copy link

Fixes: http://tracker.ceph.com/issues/17725

Signed-off-by: Joao Eduardo Luis <joao@suse.de>
(cherry picked from commit c9d46cf)
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
(cherry picked from commit 20dcb59)
@Abhishekvrshny Abhishekvrshny changed the base branch from jewel to jewel-next November 15, 2016 16:45
@Abhishekvrshny Abhishekvrshny added this to the jewel milestone Nov 15, 2016
@Abhishekvrshny Abhishekvrshny self-assigned this Nov 15, 2016
@jecluis
Copy link
Member

jecluis commented Nov 16, 2016

lgtm, although the commit dropping the 'goto' statements is a lot more about aesthetics than bug fixing - i don't think it causes any harm by being backported anyway.

ghost pushed a commit that referenced this pull request Nov 23, 2016
….21.15.16:6789/0, there will be 1 monitors

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ktdreyer
Copy link
Member

@theanalyst , @athanatos , should this go in before v10.2.4?

@athanatos
Copy link
Contributor

I think this still needs to be tested. @Abhishekvrshny @dachary ?

@ghost
Copy link

ghost commented Dec 1, 2016

@athanatos @ktdreyer this is @theanalyst decision.

@theanalyst
Copy link
Member

@dachary @athanatos did this pass through an integration run already (looks harmless to include IMO)

@ghost
Copy link

ghost commented Dec 1, 2016

It was included in http://tracker.ceph.com/issues/17851#note-9 which had a flawless rados suite run at http://tracker.ceph.com/issues/17851#note-12 . Note however that this is the usual X/2000 designed for pre-merge verification and not the X/50 designed to validate a release.

@athanatos athanatos merged commit 828ac74 into ceph:jewel-next Dec 1, 2016
@ghost
Copy link

ghost commented Dec 1, 2016

@athanatos by merging in jewel-next you targeted 10.2.5. Please speak up if you wanted this pull request in 10.2.4 instead.

@athanatos
Copy link
Contributor

@dachary Sorry, didn't notice. Can you move it over?

@ghost
Copy link

ghost commented Dec 1, 2016

@athanatos I'll do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants