jewel: ceph-disk --dmcrypt create must not require admin key #12033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceph-disk --dmcrypt needs to put a config-key and authorize the OSD to get it back. The corresponding permissions are added to the bootstrap-osd profile in the monitor. When preparing the OSD lockbox, use the bootstrap-osd profile instead of implicitly requiring admin permissions to perform the initial config-key and auth get-or-create operations. Fixes: http://tracker.ceph.com/issues/17849 Signed-off-by: Loic Dachary <loic@dachary.org> (cherry picked from commit c1c6224)
ghost
self-assigned this
ghost
changed the base branch from
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2016
… require admin key Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
It passed the rados (http://tracker.ceph.com/issues/17851#note-12) suite. It also passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17851#note-15) suites. Note that it won't be included in 10.2.4, reason why it targets jewel-next. |
ghost
pushed a commit
that referenced
this pull request
Dec 5, 2016
… require admin key Reviewed-by: Loic Dachary <ldachary@redhat.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17926