rbd: use snap_remove implementation from internal #12035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorDenisov
force-pushed
the
fix_snap_remove
branch
from
9adc0ff
to
37deaf5
Compare
Signed-off-by: Victor Denisov <denisovenator@gmail.com>
VictorDenisov
force-pushed
the
fix_snap_remove
branch
from
37deaf5
to
bf9541a
Compare
|
lgtm |
|
jenkins test this please (pg_log timeout) |
ghost
approved these changes
Nov 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dillaman, I presume rbd_snap_remove should use implementation from internal.cc.
Given that now we need to check if the snapshot to be removed is from UserSnapshotNamespace.