test: ceph-objectstore-tool: should import platform before using it #12038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kefu Chai <kchai@redhat.com>
oms4suse
approved these changes
Nov 17, 2016
| @@ -31,7 +31,7 @@ def check_output(*popenargs, **kwargs): | |||
| import logging | |||
| import json | |||
| import tempfile | |||
| import io | |||
There was a problem hiding this comment.
io is definitely not used in this module so +1
| @@ -31,7 +31,7 @@ def check_output(*popenargs, **kwargs): | |||
| import logging | |||
| import json | |||
| import tempfile | |||
| import io | |||
| import platform | |||
|
|
|||
There was a problem hiding this comment.
platform is definitely used so another +1
| @@ -1967,7 +1967,7 @@ def main(argv): | |||
|
|
|||
| def remove_btrfs_subvolumes(path): | |||
| if platform.system() == "FreeBSD": | |||
| return | |||
There was a problem hiding this comment.
removing trailing whitespace is always good.
|
wkennington
pushed a commit
to wkennington/ceph
that referenced
this pull request
Dec 7, 2016
Warns about incorrect spacing near 'port' (e.g., 'port = 80'). Fixes issue ceph#12038. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 93497e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com