osd: set server-side limits on omap get operations #12059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't apply to the ops that explicitly name keys to read; those aren't as risky. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-osd-omap-limits
branch
from
4a40bd1
to
ca83d9a
Compare
xiexingguo
reviewed
Nov 18, 2016
| limit on the number of keys to return. The OSD now imposes a configurable | ||
| limit on the number of keys and number of total bytes it will respond with, | ||
| which means that a librados user might get fewer keys than they asked for. | ||
| This is necessary to prevent careless users from requesting and unreasonable |
| } | ||
| } // else return empty out_set | ||
| ::encode(out_set, osd_op.outdata); | ||
| ::encode(num, osd_op.outdata); |
There was a problem hiding this comment.
I am a little confused. We change the formatting of the result output here. May the consumers still be able to understand it correctly without making any changes?
There was a problem hiding this comment.
set encodes as a u32 followed by N strings. We encode the strings in bl above, encode teh count here (once we know it), then append bl.
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-osd-omap-limits
branch
from
ca83d9a
to
99536f3
Compare
|
jenkins test this please (eio now ignored on master) |
xiexingguo
approved these changes
Nov 18, 2016
|
@athanatos or @jdurgin mind taking a quick look? |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important to prevent a silly client from requesting unbounded
work from the OSD (like getting a max of (u64)-1 keys).