jewel: mon: OSDMonitor: only reject MOSDBoot based on up_from if inst matches #12067
Conversation
smithfarm
changed the title
smithfarm
changed the title
…ot based on up_from if inst matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@theanalyst , @athanatos , should this go in before v10.2.4? |
|
I'd like to get this into 10.2.4, but I think this still needs to be tested. @Abhishekvrshny @dachary @smithfarm ? |
|
@athanatos this is @theanalyst decision, I think. |
|
It was included in http://tracker.ceph.com/issues/17851#note-9 which had a flawless rados suite run at http://tracker.ceph.com/issues/17851#note-12 . Note however that this is the usual X/2000 designed for pre-merge verification and not the X/50 designed to validate a release. Beware: if this is merged it will be 10.2.5. To merge it in 10.2.4 the target must be changed from jewel-next to jewel. |
|
@dachary This should be switched to 10.2.4, can you take care of that? |
ghost
changed the base branch from
ghost
changed the title
|
@smithfarm could you please rebase to jewel & repush ? I changed the target branch already, as you can see ;-) |
If the osd actually restarts, there is no guarrantee that the epoch will advance past up_from. If the inst is different, it can't really be a dup. At worst, it might be a queued MOSDBoot from a previous inst, but in that case, the real inst would see itself marked up, and then back down causing it to try booting again. Fixes: http://tracker.ceph.com/issues/17899 Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 033ad5b)
smithfarm
force-pushed
the
wip-17953-jewel
branch
from
0a035f3
to
d194db8
Compare
|
@dachary done |
smithfarm
changed the title
|
The flake8 error is the only one and is expected. The rest passes. ERROR: flake8: commands failed py27: commands succeeded |
http://tracker.ceph.com/issues/17953