FreeBSD: do_freebsd.sh #12090
FreeBSD: do_freebsd.sh #12090
Conversation
| if ! grep -q ENODATA /usr/include/errno.h; then | ||
| echo Need ENODATA in /usr/include/errno.h for cython compilations | ||
| echo Please add it manually after ENOATTR with value 87 | ||
| echo '#define ENOATTR 87' |
There was a problem hiding this comment.
thought we've hidden these sort of things with compat.h...
There was a problem hiding this comment.
@tchaikov
Yup, but there is one tiny snag, called cython, that requires it to be in the include files.
All I have tried thusfar does not get me to include compat.h, I asked a bit around but got nothing that worked.
If you know a way to do this without serious post processing, I'm all up for it.
There was a problem hiding this comment.
i will try in another boring week-end.
There was a problem hiding this comment.
@wjwithagen could you provide more details on where or in which source file we need to include "compat.h" to enable cython to do the right thing on FreeBSD?
There was a problem hiding this comment.
This is one example of the final compilation that fails.
I can mail you the rados.c file if you want.
[ 54%] Built target rados
running build
running build_ext
building 'rados' extension
/usr/bin/cc -DNDEBUG -iquote/home/wjw/wip/src/include -w -fPIC -I/usr/local/include/python2.7 -I/usr/local/include/python2.7 -I/usr/local/include/python2.7 -c /home/wjw/wip/build/src/pybind/rados/rados.c -o /home/wjw/wip/build/lib/cython_modules/temp.freebsd-12.0-CURRENT-amd64-2.7/home/wjw/wip/build/src/pybind/rados/rados.o -fno-strict-aliasing -O2 -pipe -fstack-protector -fno-strict-aliasing -DNDEBUG -lpython2.7 -lintl -lutil -lm -Wl,--export-dynamic
/home/wjw/wip/build/src/pybind/rados/rados.c:50847:36: error: use of undeclared identifier 'ENODATA'
__pyx_t_2 = __Pyx_PyInt_From_int(ENODATA); if (unlikely(!__pyx_t_2)) __PYX_ERR(0, 386, __pyx_L1_error)
^
1 error generated.
There was a problem hiding this comment.
@wjwithagen, hope #12198 could address this issue.
There was a problem hiding this comment.
@tchaikov
Given the fact that we need an upstream accept from Cython (Which I already submitted) and again downstream into the FreeBSD ports, is it wise to keep the warning for the time being.
- rearrange and and more checks before building - introduce CEPH_DEV to add test/code/debugging when DEVeloping Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
wjwithagen
force-pushed
the
wip-wjw-do_freebsd.sh
branch
from
f44a578
to
84cc0dd
Compare
ghost
added
the
|
@tchaikov |
|
@tchaikov So now I'm going to harass the cython maintainer, to see when he will make an update for the port. |
Signed-off-by: Willem Jan Withagen wjw@digiware.nl