tests: fix ceph-helpers.sh wait_for_clean delays #12095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
The TENTH_TIMEOUT was not delcared as an int and failed to be set with the correct number. The test of the function did not catch this. Implement computing of the increasingly large sleep delays in a separate function so that it can be tested more easily. Give up on sub-second sleep because a the function will not sleep at all if the cluster is already clean. And if it is not already clean, it is very unlikely to become clean within less than a second. The downside of having very short sleep time is that it needlessly stress the machine and also possibly spam the logs. Refs: http://tracker.ceph.com/issues/17830 Signed-off-by: Loic Dachary <loic@dachary.org>
ghost
changed the title
ghost
mentioned this pull request
tchaikov
approved these changes
Nov 21, 2016
|
@tchaikov thanks! |
|
@dachary This could take the timeout input in seconds, but needs to have initial sleep as .1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TENTH_TIMEOUT was not delcared as an int and failed to be set with
the correct number. The test of the function did not catch this.
Implement computing of the increasingly large sleep delays in a separate
function so that it can be tested more easily. Give up on sub-second
sleep because a the function will not sleep at all if the cluster is
already clean. And if it is not already clean, it is very unlikely to
become clean within less than a second. The downside of having very
short sleep time is that it needlessly stress the machine and also
possibly spam the logs.
Refs: http://tracker.ceph.com/issues/17830
Signed-off-by: Loic Dachary loic@dachary.org