test/osd/osd-fast-mark-down.sh: remove unnecessary teardown() calls #12101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branch-predictor
suggested changes
Nov 21, 2016
| return 1 | ||
| fi | ||
| done | ||
| pkill -SIGTERM rados | ||
| teardown $dir || return 1 |
There was a problem hiding this comment.
Removing this one in particular will cause entire test to fail, even if it actually succeeded, because OSDs are not cleaned up in subsequent sub-tests.
There was a problem hiding this comment.
I agree with @branch-predictor . This is not typical of the structure of other tests but that's ok.
ghost
suggested changes
Nov 21, 2016
| return 1 | ||
| fi | ||
| done | ||
| pkill -SIGTERM rados | ||
| teardown $dir || return 1 |
There was a problem hiding this comment.
I agree with @branch-predictor . This is not typical of the structure of other tests but that's ok.
main() does this for us. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-mark-down-test-cleanup
branch
from
28d1a7c
to
60bb32a
Compare
branch-predictor
approved these changes
Nov 21, 2016
|
@dachary and @branch-predictor fixed and repushed. |
ghost
approved these changes
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main() does this for us.
Signed-off-by: Kefu Chai kchai@redhat.com