API cleanup for libcephfs interfaces #12106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in the header. Also, add a doc comment. Signed-off-by: Jeff Layton <jlayton@redhat.com>
Ensure that we can add new flags in the future by not allowing anyone to set flags that we don't currently recognize. Fixes: http://tracker.ceph.com/issues/17911 Signed-off-by: Jeff Layton <jlayton@redhat.com>
|
Oh, and I should reference this tracker bug: |
|
The code looks good but you should include "Fixes: http://tracker.ceph.com/issues/17911" in the second patch commit message, and at least one of those dead jobs is a libcephfs one so we should figure out what's going on there (we've had much more successful runs very recently). |
jcsp
approved these changes
Nov 22, 2016
jtlayton
force-pushed
the
wip-jlayton-libcephfs
branch
from
ad22a7a
to
2898865
Compare
|
Sigh... added the Fixes line and repushed, and then the build failed for some reason. Looks like: I'm guessing this is another unrelated bug, but if you guys want to sanity check that, then I'd appreciate it. |
|
the objectstore test failure is tracked at http://tracker.ceph.com/issues/17743 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of patches to do some cleanup of the statx-based APIs. The main thing we need to ensure is that no callers are setting flags that we don't currently recognize, as that would prevent us from being able to add new flags in the future.
I tried to run tests over the weekend but a bunch died, so I'm rerunning them now:
http://pulpito.ceph.com/jlayton-2016-11-21_14:46:06-fs-wip-jlayton-libcephfs---basic-mira/
Still, this patchset is pretty trivial, so I'll be surprised if it breaks anything.