mds: properly commit new dirfrag before splitting it #12125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsfortytwo
approved these changes
Nov 23, 2016
| @@ -11520,6 +11525,9 @@ void MDCache::force_readonly() | |||
|
|
|||
| void MDCache::show_subtrees(int dbl) | |||
| { | |||
| if (g_conf->mds_thrash_exports) | |||
| dbl += 5; | |||
There was a problem hiding this comment.
Is this bit supposed to be here? If you want it in-tree please make it a new commit.
CDir::is_new() check is invalid before the new directory gets journaled. Besides, it's not good to commit a directory before it gets journaled. See commit 07ccc4e for more information. Fixes: http://tracker.ceph.com/issues/17990 Signed-off-by: Yan, Zheng <zyan@redhat.com>
|
updated |
|
@jcsp, can we expect an integration branch run to be consistent about showing this fixes the issue? |
|
@gregsfortytwo yes, it's happened several times in the last couple of runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDir::is_new() check is invalid before the new directory gets
journaled. Besides, it's not good to commit a directory before
it gets journaled.
See commit 07ccc4e for more information.
Fixes: http://tracker.ceph.com/issues/17990
Signed-off-by: Yan, Zheng zyan@redhat.com