mds: don't maintain bloom filters in standby replay #12133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsfortytwo
requested changes
Nov 23, 2016
| fs=0 | ||
| for name in a b c d e f g h i j k l m n o p | ||
| do | ||
| sleep 5 # wait for daemons to make it into FSMap |
There was a problem hiding this comment.
This appears to be sleeping 5 seconds for each fs. I don't think that was meant to happen?
| CInode *in = dn->get_linkage()->get_inode(); | ||
|
|
||
| if (dn->get_linkage()->is_primary()) { | ||
| in->get_nested_dirfrags(subdirs); |
There was a problem hiding this comment.
I must be misremembering how EExport works. Why do we need to go down one level to pull out the child CDir bloom filters, but not all the way to the leaves?
There was a problem hiding this comment.
remove_blooms calls itself, it does go down to the leaves.
|
I think it's better to avoid adding bloom filter while standby replay |
added 2 commits
November 23, 2016 14:17
The daemons will get assigned to roles in the order they start otherwise. The trick is to let them all go into the FSMap first and then increase max_mds. Signed-off-by: John Spray <john.spray@redhat.com>
...and thereby avoid needing to clear them when replaying an EExport Fixes: http://tracker.ceph.com/issues/16924 Signed-off-by: John Spray <john.spray@redhat.com>
jcsp
changed the title
|
@ukernel good point, I agree. I've updated this. |
gregsfortytwo
approved these changes
Nov 23, 2016
|
Reviewed-by: Greg Farnum gfarnum@redhat.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/16924