New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-rados: implement new aio_execute #12140
python-rados: implement new aio_execute #12140
Conversation
@jdurgin safe for kraken? |
Yeah, happy to have pybind updates for kraken since they're low risk and much easier to depend on when they're in the same release as the new c function. |
2016-11-29T04:21:25.622 INFO:tasks.workunit.client.0.smithi019.stderr:====================================================================== 2016-11-29T04:21:25.622 INFO:tasks.workunit.client.0.smithi019.stderr:ERROR: test_rados.TestIoctx.test_aio_execute 2016-11-29T04:21:25.623 INFO:tasks.workunit.client.0.smithi019.stderr:---------------------------------------------------------------------- 2016-11-29T04:21:25.623 INFO:tasks.workunit.client.0.smithi019.stderr:Traceback (most recent call last): 2016-11-29T04:21:25.623 INFO:tasks.workunit.client.0.smithi019.stderr: File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest 2016-11-29T04:21:25.623 INFO:tasks.workunit.client.0.smithi019.stderr: self.test(*self.arg) 2016-11-29T04:21:25.623 INFO:tasks.workunit.client.0.smithi019.stderr: File "/home/ubuntu/cephtest/mnt.0/client.0/tmp/test_rados.py", line 837, in test_aio_execute 2016-11-29T04:21:25.623 INFO:tasks.workunit.client.0.smithi019.stderr: comp = self.ioctx.aio_exec("foo", "hello", "say_hello", b"", oncomplete=cb) 2016-11-29T04:21:25.623 INFO:tasks.workunit.client.0.smithi019.stderr:AttributeError: 'rados.Ioctx' object has no attribute 'aio_exec' http://pulpito.ceph.com/sage-2016-11-29_03:30:55-rados-wip-sage-testing---basic-smithi/584354 |
@liewegas - Oops, looks like a typo. I just about managed to work out how to run the tests a couple hours ago but haven't looked since. I should add the safe callback tests first though. |
could you add your signed-off-by to the commits as well (git commit -s adds it for you, and works with --amend) |
Merge branch 'pybind-aioexec' of https://github.com/iain-buclaw-sociomantic/ceph into wip-yuri-testing2_2016_11_30 Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
This exposes to the python API for the following C methods: * rados_aio_exec Signed-off-by: Iain Buclaw <iain.buclaw@sociomantic.com>
Signed-off-by: Iain Buclaw <iain.buclaw@sociomantic.com>
Signed-off-by: Iain Buclaw <iain.buclaw@sociomantic.com>
@jdurgin - Signed and tested. I updated the safe callback to removed the
|
thanks! looks good |
merged manually - had to remove tabs from test_rados.py for python3 |
python-rados: implement new aio_execute Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Oops, sorry about that. And thanks! |
This exposes to the python API for the following C methods:
The function was added to the C library in #11709.