client: trim_caps() do not dereference cap if it's removed #12145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this silences the warning of "Use of memory after it is freed" reported by clang static analyzer. Reported-by: Brad Hubbard <bhubbard@redhat.com> Signed-off-by: Kefu Chai <kchai@redhat.com>
|
In general I'm not too keen on changes that add complexity to satisfy a static analyser -- I think there's a simpler way to clean this up #12161 |
|
Oh, this really is just to make the static analyzer happy, too — note the session->s_cap_iterator which is set and checked to prevent exactly the static analyzer's concern. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this silences the warning of "Use of memory after it is freed" reported
by clang static analyzer.
Reported-by: Brad Hubbard bhubbard@redhat.com
Signed-off-by: Kefu Chai kchai@redhat.com