scan build fixes #12148
Merged
scan build fixes #12148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this silences the warning of Value stored to 'r' is never read. Signed-off-by: Kefu Chai <kchai@redhat.com>
this silences the warning of Value stored to 'r' is never used. Signed-off-by: Kefu Chai <kchai@redhat.com>
early return if blkid_get_cache() fails. this chance is but cosmetic, it pleases clang static analyzer which thinks that rc will be overwritten if dev is nullptr. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
commented
Nov 23, 2016
| osd->clog->error() << coll << " " << soid | ||
| << " sparse-read failed to read: " | ||
| << r << "\n"; | ||
| } if (!t.is_zero()) { |
this silences the warning of Value stored to 'r' is never used. Signed-off-by: Kefu Chai <kchai@redhat.com>
this silences the warning of The result of the '<<' expression is undefined quote from n3337, §5.8 expr.shift: If E1 has an unsigned type, the value ... (is deterministic)... Otherwise, if E1 has a signed type and non-negative value, and E1 x 2^E2 is representable in the result type, then that is the resulting value; otherwise, the behavior is undefined. Signed-off-by: Kefu Chai <kchai@redhat.com>
this silences the warning of The result of the '<<' expression is undefined quote from n3337, §5.8 expr.shift: If E1 has an unsigned type, the value ... (is deterministic)... Otherwise, if E1 has a signed type and non-negative value, and E1 x 2^E2 is representable in the result type, then that is the resulting value; otherwise, the behavior is undefined. Signed-off-by: Kefu Chai <kchai@redhat.com>
`last` points to fiemap::fm_extends[n], and if fiemap gets freed, we can not reference any of its fieldis. so we could remember the check result before freeing it. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-scan-build-fixes
branch
from
0e349bb
to
c3748fa
Compare
liewegas
approved these changes
Nov 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.