common: Add throttle_get_started perf counter #12163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Dec 2, 2016
| @@ -45,7 +46,8 @@ Throttle::Throttle(CephContext *cct, const std::string& n, int64_t m, bool _use_ | |||
| PerfCountersBuilder b(cct, string("throttle-") + name, l_throttle_first, l_throttle_last); | |||
| b.add_u64(l_throttle_val, "val", "Currently available throttle"); | |||
| b.add_u64(l_throttle_max, "max", "Max value for throttle"); | |||
| b.add_u64_counter(l_throttle_get, "get", "Gets"); | |||
| b.add_u64_counter(l_throttle_get_started, "get_started", "Number of get calls, increased before wait"); | |||
| b.add_u64_counter(l_throttle_get, "get", "Gets"); // throttle_get_started - throttle_get == no. of waiters | |||
There was a problem hiding this comment.
nit: the comment is cryptic: it should either be reworded or removed
ghost
self-assigned this
This change adds 'get_started' performance counter which is increased at the beginning of Throttle::get() call, before any potential wait is started. It's purpose is to measure in realtime the number of jobs waiting for the throttle (get_started - get) and get the characteristic of get cals before throttler does it's job. Signed-off-by: Bartłomiej Święcki <bartlomiej.swiecki@corp.ovh.com>
byo
force-pushed
the
wip-throttle-get-started-perf-counter
branch
from
9941ec7
to
8c93517
Compare
liewegas
approved these changes
Dec 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds 'get_started' performance counter which
is increased at the beginning of Throttle::get() call,
before any potential wait is started. It's purpose is
to measure in realtime the number of jobs waiting for the
throttle (get_started - get) and get the characteristic of
get cals before throttler does it's job.
Signed-off-by: Bartłomiej Święcki bartlomiej.swiecki@corp.ovh.com