tests: osd-scrub-repair.sh abort if add_something fails #12172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the script keeps going after this function fails, it will be non trivial to find the root cause of the problem. Signed-off-by: Loic Dachary <loic@dachary.org>
ghost
added
|
I ran into this while looking into http://tracker.ceph.com/issues/18018 : I don't think it helps osd-scrub-repair.sh itself in any way. It just makes it a little easier to debug. |
|
jenkins test this please (osd-crush.sh http://tracker.ceph.com/issues/18022) |
|
|
@tchaikov unfortunately this is expected and not the root cause of the error. Thanks for taking a look though :-) /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/osd-crush.sh:203: TEST_add_ruleceph osd crush rule create-simple test_rule_nospace host1 osd firstn /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/osd-crush.sh:203: TEST_add_rulegrep 'Error ENOSPC' Error ENOSPC: failed to add rule 256 because (28) No space left on device ceph-mon: mon.noname-a 127.0.0.1:7104/0 is local, renaming to mon.a ceph-mon: set fsid to 545eeeef-59ac-4bf4-b99a-921cf3046813 ceph-mon: created monfs at td/osd-crush/a for mon.a /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/osd-crush.sh:34: run: teardown td/osd-crush |
|
oh, right! |
|
jenkins test this please (test_objectstore_memstore.sh http://tracker.ceph.com/issues/18027) |
tchaikov
approved these changes
Nov 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the script keeps going after this function fails, it will be non
trivial to find the root cause of the problem.
Signed-off-by: Loic Dachary loic@dachary.org