mds: don't access mdsmap from log submit thread #12208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems kind of redundant to store a copy of this for every event. What if we had a copy on MDLog that was read only by submit_thread and updated from MDSRank::handle_mds_map when the up features changed? |
the log submit thread does not hold the big mds_lock. Fixes: http://tracker.ceph.com/issues/18047 Signed-off-by: Yan, Zheng <zyan@redhat.com>
|
jenkins test this please (https://jenkins.ceph.com/job/ceph-pull-requests/15088/ has readable.sh failure) |
jcsp
approved these changes
Dec 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the log submit thread does not hold the big mds_lock.
Fixes: http://tracker.ceph.com/issues/18047
Signed-off-by: Yan, Zheng zyan@redhat.com