rgw/rgw_rados: do not omap_getvals with (u64)-1 max (updated) #12224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yehudasa
force-pushed
the
wip-rgw-list-all
branch
from
f3ad8a0
to
d771838
Compare
Fixes: http://tracker.ceph.com/issues/17985 This will make the OSD fall over if the object is big and the OSD doesn't impose it's own fail-safe limit. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
reviewed
Nov 29, 2016
| if (r < 0) { | ||
| return r; | ||
| } | ||
| if (t.empty()) { | ||
| break; | ||
| } | ||
| done = (t.size() < count); |
There was a problem hiding this comment.
It's possible for the OSD to return fewer entries and not be at the end.
There was a problem hiding this comment.
(For example, there is a now an omap get limit that's enforced at the osd to work around client code like this)
There was a problem hiding this comment.
@liewegas in that case, we need to have omap_getvals() to also return is_truncated
yehudasa
force-pushed
the
wip-rgw-list-all
branch
from
d771838
to
99e866f
Compare
|
@liewegas updated |
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
liewegas
approved these changes
Nov 29, 2016
|
jenkins test this please (https://jenkins.ceph.com/job/ceph-pull-requests/15081/console fails readable.sh) |
|
jenkins test this please (osd-crush.sh) |
|
passed my teuthology run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/17985