libcephfs and test suite fixes #12228
Conversation
| return r; | ||
| ceph_conf_read_file(admin, NULL); | ||
| ceph_conf_parse_env(admin, NULL); | ||
| ceph_conf_set(admin, "client_permissions", "false"); |
There was a problem hiding this comment.
Is setting client_permissions to false really necessary? I'm not really familiar with this but found it curious.
There was a problem hiding this comment.
Yes. Otherwise, the client will apparently try to enforce permissions, and that prevents an unprivileged user process from doing a chown. We could also do this by creating a UserPerm object and using ceph_ll_setattr, but this is simpler and the code already existed.
We might want to merge this with the routine in access.cc though. Maybe I'll move it into test.cc ? OTOH, that means adding a header file too, so maybe I'll leave it as-is...
There was a problem hiding this comment.
s/chown/chmod/?
Leaving it as-is is fine with me. Thanks for the explanation.
jtlayton
force-pushed
the
wip-jlayton-umount
branch
from
a9a1a63
to
3691b7a
Compare
As Zheng points out, declaring an InodeRef before you take the mutex means that its destructor gets called after the mutex has already been released. Handling the refcount however, requires that you hold the mutex so this could cause refcount leaks if two threads do a load/decrement/store at the same time. Reverse the order. Adding a fixes line here for the currently reported bug, but it's not yet clear whether this will fix it. Fixes: http://tracker.ceph.com/issues/17982 Signed-off-by: Jeff Layton <jlayton@redhat.com>
…ore testing Patrick noticed that the libcephfs tests failed to run unless they were run after the ceph-fuse tests had run. The ceph-fuse tests set the root of the share to mode 01777, but the libcephfs tests don't do that even though they rely on the directory being world-writable. Fix this by adding a new main() function for ceph_test_libcephfs, and calling a function (copied from access.cc) that resets the permissions of the root before running the tests. Fixes: http://tracker.ceph.com/issues/18013 Signed-off-by: Jeff Layton <jlayton@redhat.com>
jtlayton
force-pushed
the
wip-jlayton-umount
branch
from
3691b7a
to
8a887ed
Compare
|
Did a fs suite run and it shows some failures. I think they're probably unrelated to these changes, but I'll go over them before merging to make sure: http://pulpito.ceph.com/jlayton-2016-11-30_18:27:59-fs-wip-jlayton-umount---basic-smithi/ |
|
I don't see any evidence that this PR caused the test failures, so I'm going to go ahead and merge. |
This should fix http://tracker.ceph.com/issues/18013 and might also fix http://tracker.ceph.com/issues/17982. Build is running now and I'll plan to run tests on it once it's complete.