osdc/Objecter: fix relock race #12234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit a863ae1 we tried to fix a race but failed because we didn't update the session pointer. Add a proper test for this case with a delay injection and fix the bug. Fixes: http://tracker.ceph.com/issues/17942 Signed-off-by: Sage Weil <sage@redhat.com>
|
@tchaikov mind looking? |
|
no, looking. |
tchaikov
approved these changes
Nov 30, 2016
|
the failed test is fixed by #12235 |
tchaikov
approved these changes
Nov 30, 2016
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit a863ae1 we tried
to fix a race but failed because we didn't update the
session pointer. Add a proper test for this case with
a delay injection and fix the bug.
Fixes: http://tracker.ceph.com/issues/17942
Signed-off-by: Sage Weil sage@redhat.com