bufferlist: fix the bug of memory consolidation #12237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yankun Li <lioveni99@gmail.com>
YankunLi
force-pushed
the
fix_bug_bufferlist
branch
from
3091252
to
9d1742a
Compare
YankunLi
changed the title
tchaikov
requested changes
Nov 30, 2016
| @@ -1826,7 +1826,7 @@ static simple_spinlock_t buffer_debug_lock = SIMPLE_SPINLOCK_INITIALIZER; | |||
| if (!_buffers.empty()) { | |||
| ptr &l = _buffers.back(); | |||
| if (l.get_raw() == bp.get_raw() && | |||
| l.end() == bp.start() + off) { | |||
| l.end() == off) { | |||
There was a problem hiding this comment.
the off here is the offset inside of bp which start from _off in the backed raw data, while l.end() is the offset from the raw data. i don't think they are comparable.
There was a problem hiding this comment.
@tchaikov Thinks， but, I don't think so, the off here equal to append_buffer.end() - gap(the length of data that is append), so it is also the offset from the raw data.
|
closing this PR, as #12247 is the right fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yankun Li lioveni99@gmail.com