msg/async/rdma: fix disconnect log line #12254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuyuyu101 see PR |
yuyuyu101
reviewed
Dec 1, 2016
| @@ -335,7 +335,9 @@ int Infiniband::recv_msg(CephContext *cct, int sd, IBSYNMsg& im) | |||
| r = -errno; | |||
| lderr(cct) << __func__ << " got error " << errno << ": " | |||
| << cpp_strerror(errno) << dendl; | |||
| } else if ((size_t)r != sizeof(msg)) { // valid message length | |||
| } else if (r == 0){ // valid disconnect message of length 0 | |||
There was a problem hiding this comment.
minor: } else if (r == 0) {
space between "(" and "{"
yuyuyu101
approved these changes
Dec 1, 2016
|
@Adirl hmm, plz squash these two commits... then we can merge |
|
Done |
issue: none Change-Id: I29e2a6ae78dda3cf4a1817b9ab41bea0f636bda5 Signed-off-by: Adir Lev <adirl@mellanox.com>
|
@yuyuyu101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adir Lev adirl@mellanox.com