os/bluestore: drop old bluestore preconditioning; replace with wal preextension of file size #12265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
reviewed
Dec 2, 2016
| @@ -979,6 +979,7 @@ OPTION(bluefs_min_flush_size, OPT_U64, 65536) // ignore flush until its this bi | |||
| OPTION(bluefs_compact_log_sync, OPT_BOOL, false) // sync or async log compaction? | |||
| OPTION(bluefs_buffered_io, OPT_BOOL, false) | |||
| OPTION(bluefs_allocator, OPT_STR, "stupid") // stupid | bitmap | |||
| OPTION(bluefs_preextend_wal_files, OPT_BOOL, true) // this *requires* taht rocksdb has recycling enabled | |||
liewegas
force-pushed
the
wip-bluestore-precondition
branch
from
d99da65
to
23a29c6
Compare
This doesn't work, it's slow, and it's hacky. Signed-off-by: Sage Weil <sage@redhat.com>
When rocksdb has log recycling on (this is required!), it will do robust checksums on log records and change playback behavior to tolerate trailing garbage in the log file. This normally allows it to overwrite previous log files, but it can also let us overwrite arbitrary garbage on the device. If we allocate some new space for a .log file (already indicated by the WRITER_WAL hint), extend the size immediately so that each subsequent append doesn't have to (unless/until we do another allocation). This is safe as long as rocksdb recycling is enabled (which it is by default). This is faster because we don't have to flush the bluefs log on every log append during the period after startup before rocksdb starts recycling log files. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore-precondition
branch
from
23a29c6
to
9ae9e64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the slwo preconditioning that didn't work.
Instead, we pre-extend rocksdb log files. This is faster, simpler, but fragile in that disabling log recycling in rocksdb will break it.