Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async/rdma: event polling thread can block on event #12270

Merged
merged 1 commit into from Dec 4, 2016

Conversation

yuyuyu101
Copy link
Member

No description provided.

@yuyuyu101
Copy link
Member Author

@Adirl give a look

@yuyuyu101 yuyuyu101 force-pushed the wip-rdma-polling branch 2 times, most recently from 1062b8f to eff13c3 Compare December 2, 2016 06:07
Signed-off-by: Haomai Wang <haomai@xsky.com>
@Adirl
Copy link

Adirl commented Dec 2, 2016

  •  if ((ceph_clock_now(cct) - last_inactive).to_nsec() / 1000 > cct->_conf->ms_async_rdma_polling_us) {
    

maybe should be with *:

  •  if ((ceph_clock_now(cct) - last_inactive).to_nsec() * 1000 > cct->_conf->ms_async_rdma_polling_us) {
    

@yuyuyu101
Copy link
Member Author

@Adirl not follow.. to_nsec() is nanoseconds(ns). we need to divide 1000 to become microseconds(us)

@Adirl
Copy link

Adirl commented Dec 2, 2016

@yuyuyu101
correct, i checked again, my bad :)

@Adirl
Copy link

Adirl commented Dec 2, 2016

@yuyuyu101
patch looks important and good to me,

consider this corner case:
since you do "continue" after "rearm=true" it could be that when returning to poll_cq() now gets many cqe's and therefore won't never go again into if(!n). meaning blocking on poll() we never happen. is that allowed?
hope i explained it well, let me know for any question

@yuyuyu101
Copy link
Member Author

@Adirl why? if set rearm to true and got many cqe, after processing cqe we still can call poll. why it never happen?

@Adirl
Copy link

Adirl commented Dec 2, 2016

If they stop arriving so yes, you can get to poll

@yuyuyu101 yuyuyu101 merged commit f502763 into ceph:master Dec 4, 2016
@yuyuyu101 yuyuyu101 deleted the wip-rdma-polling branch December 4, 2016 12:24
@yuyuyu101 yuyuyu101 added this to the kraken milestone Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants