mds: misc multimds fixes #12274
mds: misc multimds fixes #12274
Conversation
| for (auto p : dfls) { | ||
| if (mds->get_nodeid() != p->get_dir_auth().first) | ||
| witnesses.insert(p->get_dir_auth().first); | ||
| } |
There was a problem hiding this comment.
If we don't make other replicas a witness here, at which point do they find out the inode has been unlinked?
There was a problem hiding this comment.
Server::_unlink_local_finish send dentry unlink message to the rest replicas
| @@ -2049,6 +2055,10 @@ void Locker::resume_stale_caps(Session *session) | |||
| if (cap->is_stale()) { | |||
| dout(10) << " clearing stale flag on " << *in << dendl; | |||
| cap->clear_stale(); | |||
|
|
|||
| if (in->state_test(CInode::STATE_EXPORTINGCAPS)) | |||
| continue; | |||
There was a problem hiding this comment.
This is subtle; can you explain in the commit message? I think this is assuming we're the recipient and can just toss out the stale caps now, right?
ukernel
force-pushed
the
wip-multimds-misc
branch
from
2cc8fe7
to
ea563bd
Compare
|
jenkins test this please (asok http://tracker.ceph.com/issues/15249) |
ukernel
force-pushed
the
wip-multimds-misc
branch
from
ea563bd
to
72e1edd
Compare
Its caller StrayManager::eval_remote_stray uses projected linkage. Signed-off-by: Yan, Zheng <zyan@redhat.com>
Signed-off-by: Yan, Zheng <zyan@redhat.com>
This avoid trigger the assertion of path traverse return value in Server::handle_slave_rmdir_prep. (Other witness mds may release the inode before receiving the slave rmdir prepare) Signed-off-by: Yan, Zheng <zyan@redhat.com>
The revoke/resume cycle increases capability's sequence, which confuses clients. The caps get removed if exporting succeeds. We only need to revoke/resume stale caps after exporting fails. Signed-off-by: Yan, Zheng <zyan@redhat.com>
Rollback slave operations is tricky. Make MDcache::request_kill ignores request that has started slave operations. Signed-off-by: Yan, Zheng <zyan@redhat.com>
ukernel
force-pushed
the
wip-multimds-misc
branch
from
72e1edd
to
315ef14
Compare
|
@ukernel, you appear to have pushed a bunch of new and unrelated bug fix commits on top of an already-reviewed PR? It'll help if you don't apply new ones once a PR has been looked at so it's clear what has and hasn't been reviewed. |
| srcdnl->get_inode()->filelock.remove_dirty(); | ||
| srcdnl->get_inode()->nestlock.remove_dirty(); | ||
| */ |
There was a problem hiding this comment.
Why do you want to leave this in comments instead of removing the code?
| cache->adjust_subtree_auth(dir, mds->get_nodeid()); | ||
| cache->try_subtree_merge(dir); // NOTE: this may journal subtree_map as side effect | ||
| dir->unfreeze_tree(); |
There was a problem hiding this comment.
What's up with these ordering changes? If they're necessary for correctness we need to at least document that, if not enforce it with code state.
(Seriously, this change implies an ordering that allows unfreeze before or after adjusting auth and merging, but doesn't work in both orders.)
| @@ -89,7 +89,6 @@ class Migrator { | |||
| set<mds_rank_t> warning_ack_waiting; | |||
| set<mds_rank_t> notify_ack_waiting; | |||
| map<inodeno_t,map<client_t,Capability::Import> > peer_imported; | |||
| list<MDSInternalContextBase*> waiting_for_finish; | |||
There was a problem hiding this comment.
"mds: remove useless code in Migrator"
With commits like that it's best to say exactly why it's useless. In this case, I gather nobody ever put anything on waiting_for_finish or called add_export_finish_waiter(), but the commit should say so.
| bufferlist::iterator blp = client_map.begin(); | ||
| ::decode(cm, blp); | ||
| mds->server->prepare_force_open_sessions(cm, seqm); | ||
| mds->server->finish_force_open_sessions(cm, seqm); | ||
| mds->sessionmap.open_sessions(cm); |
There was a problem hiding this comment.
I don't understand why this change is being made at all. I think maybe the commit means you want to switch to doing this, but I'm not sure why. It looks like you're just tossing out a bunch of asserts and other safety/metadata code.
There was a problem hiding this comment.
Okay, makes sense that trying to use the same code on both import and replay wouldn't work.
LogSegment::try_to_expire() calls Locker::scatter_nudge() for dirty scatter locks. If lock's parent is non-auth, Locker::scatter_nudge() waits on the stable bit of corresponding lock. There are some cases that scatter locks get marked clean without involving lock state transition. We need to wake up scatter_nudge waiters in these cases. Also remove the code that clear dirty scatter locks after inode gets imported. I can't see why we should do that. Signed-off-by: Yan, Zheng <zyan@redhat.com>
SessionMap::open_sessions() is used by ESessions::replay() to open sessions that were opened by Server::prepare_force_open_sessions(). Server::prepare_force_open_sessions() increases session map's version for each opened sessions. But SessionMap::open_sessions() only increases session map's version by one. Signed-off-by: Yan, Zheng <zyan@redhat.com>
Server::finish_force_open_sessions() send session open message to clients. It's wrong to use it during log replay. Signed-off-by: Yan, Zheng <zyan@redhat.com>
ukernel
force-pushed
the
wip-multimds-misc
branch
from
7d31048
to
90c7e34
Compare
|
updated |
|
Reviewed-by: Greg Farnum gfarnum@redhat.com |
No description provided.