os/bluestore: dedup omap_head, reuse nid instead #12275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
xxg-wip-bluestore-1202
branch
from
d09cc94
to
c3364a0
Compare
liewegas
reviewed
Dec 2, 2016
| @@ -667,7 +667,7 @@ struct bluestore_onode_t { | |||
| uint64_t nid = 0; ///< numeric id (locally unique) | |||
| uint64_t size = 0; ///< object size | |||
| map<string, bufferptr> attrs; ///< attrs | |||
| uint64_t omap_head = 0; ///< id for omap root node | |||
| uint8_t omap_head_exist = 0; ///< true if omap truly used | |||
There was a problem hiding this comment.
how about uint8_t flags = 0;
and
enum {
FLAG_OMAP = 1;
};
and teh usual test_flag, set_flag, clear_flag helpers, plus a has_omap() helper?
xiexingguo
force-pushed
the
xxg-wip-bluestore-1202
branch
3 times, most recently
from
f37203a
to
610d794
Compare
This is faster and save us some memory as well as space. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-1202
branch
from
610d794
to
4339b42
Compare
|
done. |
which is optimal. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
approved these changes
Dec 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is faster and save us some memory as well as space.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn