cleanup: use std::make_shared to replace new

[wycbox]

Signed-off-by: Yunchuan Wen yunchuan.wen@kylin-cloud.com

[gregsfortytwo]

Looks good at a quick glance. @wwformat, did you use some kind of script to pick these out? Be helpful if you can share it. :)

[tchaikov]

nit, why not use auto instead?

[wycbox]

I feel the 'auto' keyword is suitable for complex template declare

[wycbox]

OK, I have updated and use auto keyword.

[tchaikov]

/home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1842: test_mon_ping:  ceph ping 'mon.*'
...
Error connecting to cluster: TimedOut
...
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1: test_mon_ping:  rm -fr /tmp/cephtool.T95
...

The following tests FAILED:
	  5 - cephtool-test-mon.sh (Failed)

retest this please.

[wycbox]

retest this please.

I repeat the test, and the step is:
cd /root/develop/ceph-builder/build
../src/test/cephtool-test-mon.sh

The result is:
/root/develop/ceph-builder/qa/workunits/cephtool/test.sh:2033: main: echo OK
OK
/root/develop/ceph-builder/qa/workunits/cephtool/test.sh:1: main: rm -fr /tmp/cephtool.3z4

[tchaikov]

@wwformat sorry for the confusion, "retest this please" was a command for jenkins to re-trigger the build/test job. i wanted to see if the failure is transient or not.

[gregsfortytwo]

Still wondering how you found/picked out these ones. In the MDS "grep 'new Mutation'" matches the count of changed ones here, but there are several other shared_ptr typedefs which haven't been hit. Are these just the ones you know about and were bugging you? Was there some single script, or set of scripts we'll get another PR on? :)

[wycbox]

Still wondering how you found/picked out these ones. In the MDS "grep 'new Mutation'" matches the count of changed ones here, but there are several other shared_ptr typedefs which haven't been hit. Are these just the ones you know about and were bugging you? Was there some single script, or set of scripts we'll get another PR on? :)

There are many declare of shared_ptr like XXXRef or XXX::Ref.
So, I use a very simple script to filter the code, and pick the right result manullay.
#/bin/bash
git grep -E "^( |\t)[a-zA-Z0-9_]+(::[a-zA-Z0-9_]+)( )+[a-zA-Z0-9_]+(::[a-zA-Z0-9_]+)( |\t)(( |\t)new( |\t)+" | grep Ref
git grep -E "=( )[a-zA-Z0-9_]+(::[a-zA-Z0-9_]+)( |\t)(( |\t)*new( |\t)+" | grep Ref