osd: fixes to make rbd on ec work #12305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned offset Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
The offending transaction was [call rbd.copyup,delete] on a non-existent object. PGTransaction incorrectly ended up with Create and delete_first causing a transaction beginning with trying to collection_move_rename a non-existent head object. In fact, if we delete an object which the transaction currently claims to be creating, the transaction should show as empty (for that object). Rather than going through the normal write pipeline for that case, let's just record a 0 error code in the log and call it a day. That way, the transaction generating code only needs to worry about about updates to actual objects. Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
If the state is flipped, ops already in the pipeline need to continue to maintain it. Signed-off-by: Samuel Just <sjust@redhat.com>
This way, the replies come back in order and we don't expose uncommitted results. Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
This way, we can deal with waiting_for_commit appropriately. Also, add more debugging to new_repop and already_*. Signed-off-by: Samuel Just <sjust@redhat.com>
This was always a pretty silly concept and it has gotten in the way of something else. Signed-off-by: Samuel Just <sjust@redhat.com>
Up to now, the repop machinery depended on all repops commiting and applying in order. For MOSDPGUpdateLogMissing operations, however, we don't really want to send two messages in the ECBackend case. Instead, just allow those repops to skip the applied stage and be completed in order once the repops ahead of them finish. Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
…e op This isn't really important, but it's nice to be consistent with OSD::reply_op_error. Yet another reason to do away with the ack flag. Signed-off-by: Samuel Just <sjust@redhat.com>
Now that repops can represent an error, we need to remember the error code so that we can reply to waiting_for_* messages with the right value. Signed-off-by: Samuel Just <sjust@redhat.com>
|
http://pulpito.ceph.com/samuelj-2016-12-04_06:16:17-rados-wip-sam-testing---basic-smithi/ -- 1 failure, unrelated mon valgrind thing Seems to be ready to merge. |
|
Merge ceph/ceph-qa-suite#1299 at the same time. |
liewegas
changed the title
liewegas
approved these changes
Dec 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.