Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jewel: rgw: multisite requests failing with '400 Bad Request' with civetweb 1.8 #12313

Merged
merged 1 commit into from Feb 1, 2017
Merged

jewel: rgw: multisite requests failing with '400 Bad Request' with civetweb 1.8 #12313

merged 1 commit into from Feb 1, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 5, 2016

@ghost ghost self-assigned this Dec 5, 2016
@ghost ghost added this to the jewel milestone Dec 5, 2016
@ghost ghost added bug-fix rgw labels Dec 5, 2016
@ghost ghost changed the base branch from jewel to jewel-next December 5, 2016 09:01
@cbodley @ldachary
rgw: only set CURLOPT_UPLOAD for PUT/POST requests
ece622d 
when set on GET requests, curl sends a 'Transfer-encoding: chunked'
header, but doesn't do the actual encoding to terminate the message

Fixes: http://tracker.ceph.com/issues/17822

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit f3a0c40)
@ghost
Copy link
Author

ghost commented Dec 5, 2016

jenkins test this please (unittest_throttle)

ghost pushed a commit that referenced this pull request Dec 5, 2016
Merge pull request #12313: jewel: multisite requests failing with '40…
0d446b3 
…0 Bad Request' with civetweb 1.8

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost changed the base branch from jewel-next to jewel December 21, 2016 23:26
@ghost
Copy link
Author

ghost commented Dec 21, 2016

check this please

@smithfarm smithfarm changed the title jewel: multisite requests failing with '400 Bad Request' with civetweb 1.8 jewel: rgw: multisite requests failing with '400 Bad Request' with civetweb 1.8 Feb 1, 2017
@smithfarm smithfarm merged commit e371af6 into ceph:jewel Feb 1, 2017
@smithfarm
Copy link
Contributor

This passed rgw runs at http://tracker.ceph.com/issues/17851#note-50 and http://tracker.ceph.com/issues/17851#note-58

@smithfarm
Copy link
Contributor 

(11:46:45 AM) smithfarm: owasserm: thanks. For jewel integration rgw, then, what it comes down to is verifying that these 6 valgrind failures are all libtcmalloc-related: http://pulpito.front.sepia.ceph.com/smithfarm-2017-01-31_12:35:14-rgw-wip-jewel-backports-distro-basic-smithi/
(11:46:58 AM) smithfarm: owasserm: I will do that now
(11:47:05 AM) owasserm: smithfarm, thanks
(11:47:33 AM) smithfarm: owasserm: and assuming they are tcmalloc related, you said I can directly merge all the rgw PRs? Or do you want me to ask you for review in the PRs first?
(11:47:53 AM) owasserm: smithfarm, yes you can merge them
(11:48:19 AM) smithfarm: ok, will merge and do at least one or two more rgw runs before passing 10.2.6 to QE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix rgw
Projects
None yet
Milestone
jewel
2 participants
@smithfarm @cbodley