os/bluestore: flush before enumerating omap values #12328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a few update ops we enumerate omap keys (to remove them). Make sure we flush the pipeline before doing so or else we may lose keys inserted by a previous transaction that hasn't yet committed. Fixes: http://tracker.ceph.com/issues/18140 Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore-flush
branch
from
d550a5b
to
1e042a9
Compare
xiexingguo
reviewed
Dec 6, 2016
| @@ -8501,6 +8503,7 @@ int BlueStore::_omap_rmkey_range(TransContext *txc, | |||
| if (!o->onode.has_omap()) { | |||
| goto out; | |||
| } | |||
| o->flush(); | |||
|
_omap_rmkeys is fine because it doesn't read from the kv store, so it's safe to pipeline
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a few update ops we enumerate omap keys (to remove them).
Make sure we flush the pipeline before doing so or else we may
lose keys inserted by a previous transaction that hasn't yet
committed.
Fixes: http://tracker.ceph.com/issues/18140
Signed-off-by: Sage Weil sage@redhat.com