Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have ceph clear setuid/setgid bits on chown #12331

Merged
merged 4 commits into from
Dec 8, 2016
Merged

Have ceph clear setuid/setgid bits on chown #12331

merged 4 commits into from
Dec 8, 2016

Commits on Dec 7, 2016

  1. test: remove improper casts from SetSize test 

    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    @jtlayton
    jtlayton committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    58345df View commit details
    Browse the repository at this point in the history

  2. test: add new testcase for clearing setuid/setgid bits on chown/chgrp 

    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    @jtlayton
    jtlayton committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    3d7fa89 View commit details
    Browse the repository at this point in the history

  3. mds: clear setuid/setgid bits on ownership changes 

    If we get a ownership change, POSIX mandates that you clear the
setuid and setgid bits unless you are "appropriately privileged", in
which case the OS is allowed to leave them intact.

Linux however always clears those bits, regardless of the process
privileges, as that makes it simpler to close some potential races.
Have ceph do the same.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
    @jtlayton
    jtlayton committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    6da7250 View commit details
    Browse the repository at this point in the history

  4. client: drop setuid/setgid bits on ownership change 

    When we hold exclusive auth caps, then the client is responsible for
handling changes to the mode. Make sure we remove any setuid/setgid
bits on an ownership change.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
    @jtlayton
    jtlayton committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    18d2499 View commit details
    Browse the repository at this point in the history