os/bluestore: simplify allocator release flow #12343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liewegas Will take this patch and apply multi kv_sync on top..Will keep you posted on this.. |
liewegas
force-pushed
the
wip-bluestore-release
branch
from
c5ecb76
to
fd6b8a1
Compare
|
rebased on latest master, which now includes the bitalloc dump |
|
@liewegas , looks good to me. |
|
@liewegas I am seeing some degradation after porting my multi kv_sync changes on top of these commits + latest master. Not sure if it is because of the allocator changes or something else (because I was working on probably 3 weeks old master). Will revert these commits and see. |
|
@liewegas , I think we should remove TBD comment in BitMapAllocator.cc for making commiting logic concurrent:
|
liewegas
force-pushed
the
wip-bluestore-release
branch
from
fd6b8a1
to
ce35496
Compare
Wait until after the kv transaction commits, and then
release extents directly into the usable pool.
This will let us remove the commit_{start,end} business.
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Don't rely on the Allocator to do this for us (that is about to go away!). Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
This mimics, roughly, open(..., O_WRONLY|O_CREAT, ...) seek(...) if (len > 0) write(...) Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore-release
branch
from
ce35496
to
a411f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for the allocator to coordinate with the kv commit cycle. Instead,
make it hte caller's responsibility to not release extents until their dereference
has been committed.